Reorganize main architecture sections and fix numbering#2
Merged
nuniesmith merged 1 commit intomainfrom Feb 21, 2026
Merged
Conversation
- Replace 0.x numbering with Roman numerals (I-IV) by promoting
subsections to sections with \Roman{section} formatting
- Reorder: core architecture (Doya-Hassabis, Dual-Process) now precedes
crowding/co-impact specifics
- Remove defensive "not a loose metaphor" framing from Doya-Hassabis
section; lead with positive architectural description
- Rewrite section intros to lead with the topic itself rather than
explaining motivation/why first (crowding, dual-process sections)
- Rename "Why Current Systems Are Vulnerable" to "Vulnerability in
Current Systems" and "The Problem: Co-Impact..." to "Co-Impact..."
- Restore arabic numbering at Part 2 boundary
https://claude.ai/code/session_01QKmhKWaHZmRuPaazv77C6f
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Pull request overview
This PR restructures Part I (Main Architecture) of the JANUS trading system documentation to improve narrative flow and establish theoretical foundations before practical applications. The reorganization moves neuroscience framework sections earlier in the document and implements a dual numbering scheme: Roman numerals for Part I sections and Arabic numerals for Part II onwards.
Changes:
- Reorganized Part I sections to present Doya-Hassabis framework and dual-process architecture immediately after Quant 4.0 introduction, before crowding analysis
- Implemented Roman numeral section numbering (
\Roman{section}) for Part I and reverted to Arabic numerals (\arabic{section}) for Part II - Converted unnumbered "Overview" section to numbered "The Epistemological Transition to Quant 4.0" section, and upgraded subsection hierarchy levels for proper nesting
Comments suppressed due to low confidence (3)
project_janus/janus.tex:301
- The original version of this subsection included an explicit disclaimer: "We do not claim that the implementations are biologically realistic at the cellular or circuit level." This disclaimer has been removed. Consider whether this disclaimer should be retained to maintain scientific rigor and manage reader expectations about the level of biological fidelity in the implementation.
\citet{hassabis2017neuroscience} articulated the programmatic statement for neuroscience-inspired AI: the goal is \textit{functional} inspiration, not biological simulation. JANUS adopts this position, with brain-region mappings in Part~\ref{part:neuro} justified by functional analogy---each region implements a computational principle (e.g., supervised error correction, reinforcement-driven action selection, episodic memory replay) that addresses a specific trading requirement.
project_janus/janus.tex:319
- The original version made a stronger claim that the dual-process separation "has been extensively studied but never operationalized as a computational trading architecture" and that "JANUS is the first system to implement this separation as a concrete engineering design." This assertion about being "first" has been removed. Consider whether this stronger claim should be retained if it's accurate, as it emphasizes the novelty of the contribution.
JANUS separates real-time perception and action from offline memory consolidation, implementing Dual-Process Theory \citep{kahneman2011thinking, evans2008dual, evans2013dualprocess} as a concrete engineering design. The system divides into two complementary services:
project_janus/janus.tex:266
- The phrase "does not merely iterate on existing statistical methods but fundamentally" was removed, simplifying to just "reimagines". While this makes the sentence more concise, it slightly weakens the contrast being established between JANUS and prior approaches. Consider whether the stronger contrast helps communicate the paradigm shift more effectively.
This architecture reimagines the financial agent as a biological entity---one that perceives, reasons, remembers, and fears.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restructured the Main Architecture part (Part I) to improve logical flow and readability. Reorganized sections to present the Doya-Hassabis framework and dual-process architecture earlier in the narrative, before the detailed crowding analysis. Fixed section numbering to use Roman numerals for Part I and Arabic numerals for Part II.
Key Changes
\Roman{section}) for sections and subsections\arabic{section})\subsubsection*entries to\subsection*for "Historical Evolution of Quantitative Finance" and crowding-related subsections to maintain proper hierarchyImplementation Details
The reorganization creates a clearer narrative arc:
This structure better supports the paper's argument that JANUS's architecture is grounded in established neuroscience and cognitive science theory before demonstrating its practical advantages.
https://claude.ai/code/session_01QKmhKWaHZmRuPaazv77C6f